feat(sandcastle): implementer + reviewer prompts include fallow audit
This commit is contained in:
@@ -41,9 +41,10 @@ pnpm typecheck # TS brand-slot enforcement, 0s
|
|||||||
pnpm lint # ESLint rules incl. conformance/* — <1s
|
pnpm lint # ESLint rules incl. conformance/* — <1s
|
||||||
pnpm test --filter @repo/<feature> # tests for the feature you touched
|
pnpm test --filter @repo/<feature> # tests for the feature you touched
|
||||||
pnpm conformance # cross-feature event closure
|
pnpm conformance # cross-feature event closure
|
||||||
|
pnpm fallow:audit # whole-codebase analysis: dead exports, dupes, circular deps, complexity
|
||||||
```
|
```
|
||||||
|
|
||||||
All four pass before you commit. If any fail, fix or report BLOCKED — do not paper over.
|
All five pass before you commit. If any fail, fix or report BLOCKED — do not paper over.
|
||||||
|
|
||||||
## Commit message format
|
## Commit message format
|
||||||
|
|
||||||
|
|||||||
@@ -31,6 +31,7 @@ If you suspect the implementer hand-rolled what should have been generator outpu
|
|||||||
3. **Manifest-first ordering**: if a new use case landed, the manifest was updated; tests exist; the factory was wrapped at bind time.
|
3. **Manifest-first ordering**: if a new use case landed, the manifest was updated; tests exist; the factory was wrapped at bind time.
|
||||||
4. **Conformance gates**: the diff's tests + lint + typecheck pass. (You don't run them yourself; sandcastle's CI step does. Trust the CI status, reject if it's red.)
|
4. **Conformance gates**: the diff's tests + lint + typecheck pass. (You don't run them yourself; sandcastle's CI step does. Trust the CI status, reject if it's red.)
|
||||||
5. **Generator-first**: see the section above. Hand-rolled code that should have been generated is a rejection.
|
5. **Generator-first**: see the section above. Hand-rolled code that should have been generated is a rejection.
|
||||||
|
6. **Fallow audit**: verify the implementer ran `pnpm fallow:audit` and it passed. If their diff increases dead exports / dupes / circular deps / complexity beyond the baseline, that's a rejection cause unless the implementer's notes explicitly justify it.
|
||||||
|
|
||||||
## Output format
|
## Output format
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user