fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

docs(core-events): clarify subscribe consumerFeature + failFast drop

Browse Source 
Code-quality review nits: IEventBus.subscribe docstring said "debug
tag" but InMemoryEventBus actually ignores the param entirely. Also
add a comment to InMemoryEventBus.publish noting that under failFast
only the first rejection rethrows; other failures are intentionally
dropped.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Danijel Martinek
2026-05-08 12:02:45 +02:00
parent 430c831743
commit 05f0b02856
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core-events/src/event-bus.interface.ts
View File

@@ -11,8 +11,8 @@ export interface IEventBus {
/** /**
* Subscribe a handler. `consumerFeature` is the kebab-case name of the * Subscribe a handler. `consumerFeature` is the kebab-case name of the
* subscribing feature (e.g., "marketing-pages"). InMemoryEventBus uses it * subscribing feature (e.g., "marketing-pages"). It is unused by
* only as a debug tag; PayloadJobsEventBus uses it to name the fan-out task * InMemoryEventBus; PayloadJobsEventBus uses it to name the fan-out task
* slug deterministically (`__events.<event>.<consumerFeature>`). * slug deterministically (`__events.<event>.<consumerFeature>`).
*/ */
subscribe<T>( subscribe<T>(

2
packages/core-events/src/in-memory-event-bus.ts
View File

@@ -24,6 +24,8 @@ export class InMemoryEventBus implements IEventBus {
); );
if (this.options.failFast) { if (this.options.failFast) {
const failure = settled.find((s) => s.status === "rejected"); const failure = settled.find((s) => s.status === "rejected");
// Only the first rejection is rethrown. Other failures are intentionally
// dropped — `failFast` is a test-affordance, not a fault-tolerance design.
if (failure && failure.status === "rejected") throw failure.reason; if (failure && failure.status === "rejected") throw failure.reason;
} }
} }