fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

refactor(marketing-pages): factory-style use cases + per-use-case controllers

Browse Source 
- Use cases (get-page-by-slug, get-site-settings) → factory functions with I*UseCase aliases
- Controllers split: pages.controller.ts → 2 single-responsibility files
- DI module wires factories with .toDynamicValue()
- tRPC router resolves controllers via container

Refactor log: §2, §3, §4.1, §4.2, §5.1
Spec: §6.3

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Danijel Martinek
2026-05-06 00:14:27 +02:00
parent 700d311052
commit 353a41b244
15 changed files with 206 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/marketing-pages/src/application/use-cases/get-page-by-slug.use-case.test.ts
View File

@@ -1,30 +1,19 @@
import { beforeEach, describe, expect, it } from "vitest";
import { marketingPagesContainer } from "@/di/container";
import { MARKETING_PAGES_SYMBOLS } from "@/di/symbols";
import { describe, it, expect } from "vitest";
import { getPageBySlugUseCase } from "@/application/use-cases/get-page-by-slug.use-case";
import { MockPagesRepository } from "@/infrastructure/repositories/pages.repository.mock";
import type { IPagesRepository } from "@/application/repositories/pages.repository.interface";
import { getPageBySlugUseCase } from "./get-page-by-slug.use-case";
describe("getPageBySlugUseCase", () => {
let repo: MockPagesRepository;
beforeEach(() => {
if (marketingPagesContainer.isBound(MARKETING_PAGES_SYMBOLS.IPagesRepository)) {
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.IPagesRepository);
}
repo = new MockPagesRepository();
marketingPagesContainer
.bind<IPagesRepository>(MARKETING_PAGES_SYMBOLS.IPagesRepository)
.toConstantValue(repo);
});
it("returns the page when found", async () => {
const result = await getPageBySlugUseCase("about");
const repo = new MockPagesRepository();
const useCase = getPageBySlugUseCase(repo);
const result = await useCase({ slug: "about" });
expect(result?.slug).toBe("about");
});
it("returns undefined when not found", async () => {
const result = await getPageBySlugUseCase("missing-page");
const repo = new MockPagesRepository();
const useCase = getPageBySlugUseCase(repo);
const result = await useCase({ slug: "missing-page" });
expect(result).toBeUndefined();
});
});

17
packages/marketing-pages/src/application/use-cases/get-page-by-slug.use-case.ts
View File

@@ -1,13 +1,10 @@
import type { Page } from "../../entities/models/page";
import { marketingPagesContainer } from "../../di/container";
import { MARKETING_PAGES_SYMBOLS } from "../../di/symbols";
import type { IPagesRepository } from "../repositories/pages.repository.interface";
export async function getPageBySlugUseCase(
slug: string,
): Promise<Page | undefined> {
const repo = marketingPagesContainer.get<IPagesRepository>(
MARKETING_PAGES_SYMBOLS.IPagesRepository,
);
return repo.getPageBySlug(slug);
}
export type IGetPageBySlugUseCase = ReturnType<typeof getPageBySlugUseCase>;
export const getPageBySlugUseCase =
(pagesRepository: IPagesRepository) =>
async (input: { slug: string }): Promise<Page | undefined> => {
return pagesRepository.getPageBySlug(input.slug);
};

23
packages/marketing-pages/src/application/use-cases/get-site-settings.use-case.test.ts
View File

@@ -1,25 +1,12 @@
import { beforeEach, describe, expect, it } from "vitest";
import { marketingPagesContainer } from "@/di/container";
import { MARKETING_PAGES_SYMBOLS } from "@/di/symbols";
import { describe, it, expect } from "vitest";
import { getSiteSettingsUseCase } from "@/application/use-cases/get-site-settings.use-case";
import { MockSiteSettingsRepository } from "@/infrastructure/repositories/site-settings.repository.mock";
import type { ISiteSettingsRepository } from "@/application/repositories/site-settings.repository.interface";
import { getSiteSettingsUseCase } from "./get-site-settings.use-case";
describe("getSiteSettingsUseCase", () => {
let repo: MockSiteSettingsRepository;
beforeEach(() => {
if (marketingPagesContainer.isBound(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository)) {
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository);
}
repo = new MockSiteSettingsRepository();
marketingPagesContainer
.bind<ISiteSettingsRepository>(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository)
.toConstantValue(repo);
});
it("returns the seeded site settings", async () => {
const result = await getSiteSettingsUseCase();
const repo = new MockSiteSettingsRepository();
const useCase = getSiteSettingsUseCase(repo);
const result = await useCase();
expect(result.siteName).toBe("My App");
});
});

15
packages/marketing-pages/src/application/use-cases/get-site-settings.use-case.ts
View File

@@ -1,11 +1,10 @@
import type { SiteSettings } from "../../entities/models/site-settings";
import { marketingPagesContainer } from "../../di/container";
import { MARKETING_PAGES_SYMBOLS } from "../../di/symbols";
import type { ISiteSettingsRepository } from "../repositories/site-settings.repository.interface";
export async function getSiteSettingsUseCase(): Promise<SiteSettings> {
const repo = marketingPagesContainer.get<ISiteSettingsRepository>(
MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository,
);
return repo.getSiteSettings();
}
export type IGetSiteSettingsUseCase = ReturnType<typeof getSiteSettingsUseCase>;
export const getSiteSettingsUseCase =
(siteSettingsRepository: ISiteSettingsRepository) =>
async (): Promise<SiteSettings> => {
return siteSettingsRepository.getSiteSettings();
};

50
packages/marketing-pages/src/di/module.ts
View File

@@ -4,6 +4,22 @@ import type { IPagesRepository } from "../application/repositories/pages.reposit
import type { ISiteSettingsRepository } from "../application/repositories/site-settings.repository.interface";
import { MockPagesRepository } from "../infrastructure/repositories/pages.repository.mock";
import { MockSiteSettingsRepository } from "../infrastructure/repositories/site-settings.repository.mock";
import {
getPageBySlugUseCase,
type IGetPageBySlugUseCase,
} from "../application/use-cases/get-page-by-slug.use-case";
import {
getSiteSettingsUseCase,
type IGetSiteSettingsUseCase,
} from "../application/use-cases/get-site-settings.use-case";
import {
getPageBySlugController,
type IGetPageBySlugController,
} from "../interface-adapters/controllers/get-page-by-slug.controller";
import {
getSiteSettingsController,
type IGetSiteSettingsController,
} from "../interface-adapters/controllers/get-site-settings.controller";
import { MARKETING_PAGES_SYMBOLS } from "./symbols";
export const MarketingPagesModule = new ContainerModule(
@@ -14,5 +30,39 @@ export const MarketingPagesModule = new ContainerModule(
bind<ISiteSettingsRepository>(
MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository,
).to(MockSiteSettingsRepository);
bind<IGetPageBySlugUseCase>(MARKETING_PAGES_SYMBOLS.IGetPageBySlugUseCase).toDynamicValue(
(ctx) =>
getPageBySlugUseCase(
ctx.container.get<IPagesRepository>(MARKETING_PAGES_SYMBOLS.IPagesRepository),
),
);
bind<IGetSiteSettingsUseCase>(MARKETING_PAGES_SYMBOLS.IGetSiteSettingsUseCase).toDynamicValue(
(ctx) =>
getSiteSettingsUseCase(
ctx.container.get<ISiteSettingsRepository>(
MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository,
),
),
);
bind<IGetPageBySlugController>(
MARKETING_PAGES_SYMBOLS.IGetPageBySlugController,
).toDynamicValue((ctx) =>
getPageBySlugController(
ctx.container.get<IGetPageBySlugUseCase>(MARKETING_PAGES_SYMBOLS.IGetPageBySlugUseCase),
),
);
bind<IGetSiteSettingsController>(
MARKETING_PAGES_SYMBOLS.IGetSiteSettingsController,
).toDynamicValue((ctx) =>
getSiteSettingsController(
ctx.container.get<IGetSiteSettingsUseCase>(
MARKETING_PAGES_SYMBOLS.IGetSiteSettingsUseCase,
),
),
);
},
);

6
packages/marketing-pages/src/di/symbols.ts
View File

@@ -1,4 +1,10 @@
export const MARKETING_PAGES_SYMBOLS = {
IPagesRepository: Symbol.for("marketing-pages:IPagesRepository"),
ISiteSettingsRepository: Symbol.for("marketing-pages:ISiteSettingsRepository"),
// Use cases
IGetPageBySlugUseCase: Symbol.for("marketing-pages:IGetPageBySlugUseCase"),
IGetSiteSettingsUseCase: Symbol.for("marketing-pages:IGetSiteSettingsUseCase"),
// Controllers
IGetPageBySlugController: Symbol.for("marketing-pages:IGetPageBySlugController"),
IGetSiteSettingsController: Symbol.for("marketing-pages:IGetSiteSettingsController"),
} as const;

23
packages/marketing-pages/src/integrations/api/router.test.ts
View File

@@ -1,28 +1,7 @@
import { beforeEach, describe, expect, it } from "vitest";
import { marketingPagesContainer } from "@/di/container";
import { MARKETING_PAGES_SYMBOLS } from "@/di/symbols";
import { MockPagesRepository } from "@/infrastructure/repositories/pages.repository.mock";
import { MockSiteSettingsRepository } from "@/infrastructure/repositories/site-settings.repository.mock";
import type { IPagesRepository } from "@/application/repositories/pages.repository.interface";
import type { ISiteSettingsRepository } from "@/application/repositories/site-settings.repository.interface";
import { describe, it, expect } from "vitest";
import { marketingPagesRouter } from "./router";
describe("marketingPagesRouter", () => {
beforeEach(() => {
if (marketingPagesContainer.isBound(MARKETING_PAGES_SYMBOLS.IPagesRepository)) {
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.IPagesRepository);
}
if (marketingPagesContainer.isBound(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository)) {
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository);
}
marketingPagesContainer
.bind<IPagesRepository>(MARKETING_PAGES_SYMBOLS.IPagesRepository)
.toConstantValue(new MockPagesRepository());
marketingPagesContainer
.bind<ISiteSettingsRepository>(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository)
.toConstantValue(new MockSiteSettingsRepository());
});
it("exposes pageBySlug + siteSettings procedures", () => {
const names = Object.keys(marketingPagesRouter._def.procedures);
expect(names).toContain("pageBySlug");

22
packages/marketing-pages/src/integrations/api/router.ts
View File

@@ -1,16 +1,26 @@
import { z } from "zod";
import { router, publicProcedure } from "@repo/core-shared/trpc/init";
import {
getPageBySlugController,
getSiteSettingsController,
} from "../../interface-adapters/controllers/pages.controller";
import { marketingPagesContainer } from "../../di/container";
import { MARKETING_PAGES_SYMBOLS } from "../../di/symbols";
import type { IGetPageBySlugController } from "../../interface-adapters/controllers/get-page-by-slug.controller";
import type { IGetSiteSettingsController } from "../../interface-adapters/controllers/get-site-settings.controller";
export const marketingPagesRouter = router({
pageBySlug: publicProcedure
.input(z.object({ slug: z.string().min(1) }))
.query(({ input }) => getPageBySlugController(input)),
.query(({ input }) => {
const ctrl = marketingPagesContainer.get<IGetPageBySlugController>(
MARKETING_PAGES_SYMBOLS.IGetPageBySlugController,
);
return ctrl(input);
}),
siteSettings: publicProcedure.query(() => getSiteSettingsController()),
siteSettings: publicProcedure.query(() => {
const ctrl = marketingPagesContainer.get<IGetSiteSettingsController>(
MARKETING_PAGES_SYMBOLS.IGetSiteSettingsController,
);
return ctrl();
}),
});
export type MarketingPagesRouter = typeof marketingPagesRouter;

35
packages/marketing-pages/src/interface-adapters/controllers/get-page-by-slug.controller.test.ts Normal file
View File

@@ -0,0 +1,35 @@
import { describe, it, expect } from "vitest";
import { getPageBySlugController } from "@/interface-adapters/controllers/get-page-by-slug.controller";
import { getPageBySlugUseCase } from "@/application/use-cases/get-page-by-slug.use-case";
import { MockPagesRepository } from "@/infrastructure/repositories/pages.repository.mock";
import { InputParseError } from "@/entities/errors/common";
describe("getPageBySlugController", () => {
it("returns the page when found", async () => {
const repo = new MockPagesRepository();
const useCase = getPageBySlugUseCase(repo);
const controller = getPageBySlugController(useCase);
const result = await controller({ slug: "about" });
expect(result?.slug).toBe("about");
});
it("throws InputParseError on missing slug", async () => {
const repo = new MockPagesRepository();
const useCase = getPageBySlugUseCase(repo);
const controller = getPageBySlugController(useCase);
await expect(
controller({} as { slug: string }),
).rejects.toBeInstanceOf(InputParseError);
});
it("returns undefined when slug not found", async () => {
const repo = new MockPagesRepository();
const useCase = getPageBySlugUseCase(repo);
const controller = getPageBySlugController(useCase);
const result = await controller({ slug: "nonexistent" });
expect(result).toBeUndefined();
});
});

23
packages/marketing-pages/src/interface-adapters/controllers/get-page-by-slug.controller.ts Normal file
View File

@@ -0,0 +1,23 @@
import { z } from "zod";
import { InputParseError } from "../../entities/errors/common";
import type { Page } from "../../entities/models/page";
import type { IGetPageBySlugUseCase } from "../../application/use-cases/get-page-by-slug.use-case";
const inputSchema = z.object({
slug: z.string().min(1),
});
export type IGetPageBySlugController = ReturnType<typeof getPageBySlugController>;
export const getPageBySlugController =
(getPageBySlugUseCase: IGetPageBySlugUseCase) =>
async (input: Partial<z.infer<typeof inputSchema>>): Promise<Page | undefined> => {
const parsed = inputSchema.safeParse(input);
if (!parsed.success) {
throw new InputParseError("Invalid get-page-by-slug input", {
cause: parsed.error,
});
}
return getPageBySlugUseCase(parsed.data);
};

15
packages/marketing-pages/src/interface-adapters/controllers/get-site-settings.controller.test.ts Normal file
View File

@@ -0,0 +1,15 @@
import { describe, it, expect } from "vitest";
import { getSiteSettingsController } from "@/interface-adapters/controllers/get-site-settings.controller";
import { getSiteSettingsUseCase } from "@/application/use-cases/get-site-settings.use-case";
import { MockSiteSettingsRepository } from "@/infrastructure/repositories/site-settings.repository.mock";
describe("getSiteSettingsController", () => {
it("returns site settings", async () => {
const repo = new MockSiteSettingsRepository();
const useCase = getSiteSettingsUseCase(repo);
const controller = getSiteSettingsController(useCase);
const result = await controller();
expect(result.siteName).toBe("My App");
});
});

10
packages/marketing-pages/src/interface-adapters/controllers/get-site-settings.controller.ts Normal file
View File

@@ -0,0 +1,10 @@
import type { SiteSettings } from "../../entities/models/site-settings";
import type { IGetSiteSettingsUseCase } from "../../application/use-cases/get-site-settings.use-case";
export type IGetSiteSettingsController = ReturnType<typeof getSiteSettingsController>;
export const getSiteSettingsController =
(getSiteSettingsUseCase: IGetSiteSettingsUseCase) =>
async (): Promise<SiteSettings> => {
return getSiteSettingsUseCase();
};

49
packages/marketing-pages/src/interface-adapters/controllers/pages.controller.test.ts
View File

@@ -1,49 +0,0 @@
import { beforeEach, describe, expect, it } from "vitest";
import { marketingPagesContainer } from "@/di/container";
import { MARKETING_PAGES_SYMBOLS } from "@/di/symbols";
import { MockPagesRepository } from "@/infrastructure/repositories/pages.repository.mock";
import { MockSiteSettingsRepository } from "@/infrastructure/repositories/site-settings.repository.mock";
import type { IPagesRepository } from "@/application/repositories/pages.repository.interface";
import type { ISiteSettingsRepository } from "@/application/repositories/site-settings.repository.interface";
import { InputParseError } from "@/entities/errors/common";
import {
getPageBySlugController,
getSiteSettingsController,
} from "./pages.controller";
describe("pages controller", () => {
beforeEach(() => {
if (marketingPagesContainer.isBound(MARKETING_PAGES_SYMBOLS.IPagesRepository)) {
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.IPagesRepository);
}
if (marketingPagesContainer.isBound(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository)) {
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository);
}
marketingPagesContainer
.bind<IPagesRepository>(MARKETING_PAGES_SYMBOLS.IPagesRepository)
.toConstantValue(new MockPagesRepository());
marketingPagesContainer
.bind<ISiteSettingsRepository>(MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository)
.toConstantValue(new MockSiteSettingsRepository());
});
describe("getPageBySlugController", () => {
it("returns the page when found", async () => {
const result = await getPageBySlugController({ slug: "about" });
expect(result?.slug).toBe("about");
});
it("throws InputParseError on missing slug", async () => {
await expect(
getPageBySlugController({} as { slug: string }),
).rejects.toBeInstanceOf(InputParseError);
});
});
describe("getSiteSettingsController", () => {
it("returns site settings", async () => {
const result = await getSiteSettingsController();
expect(result.siteName).toBe("My App");
});
});
});

27
packages/marketing-pages/src/interface-adapters/controllers/pages.controller.ts
View File

@@ -1,27 +0,0 @@
import { z } from "zod";
import { InputParseError } from "../../entities/errors/common";
import type { Page } from "../../entities/models/page";
import type { SiteSettings } from "../../entities/models/site-settings";
import { getPageBySlugUseCase } from "../../application/use-cases/get-page-by-slug.use-case";
import { getSiteSettingsUseCase } from "../../application/use-cases/get-site-settings.use-case";
const getBySlugInputSchema = z.object({
slug: z.string().min(1),
});
export async function getPageBySlugController(input: {
slug: string;
}): Promise<Page | undefined> {
const parsed = getBySlugInputSchema.safeParse(input);
if (!parsed.success) {
throw new InputParseError("Invalid get-page-by-slug input", {
cause: parsed.error,
});
}
return getPageBySlugUseCase(parsed.data.slug);
}
export async function getSiteSettingsController(): Promise<SiteSettings> {
return getSiteSettingsUseCase();
}