refactor(navigation)!: delete navigation demo feature
Veect retrofit (ADR-027): fifth and final slice of the demo-content removal. Deletes packages/navigation whole and prunes every composition edge in one commit: core-api router mount + dep + router test, core-cms header-global composition + dep + regenerated Payload types (globals now empty), web-next bindAll (prod + dev-seed) + tests + Tailwind source + transpilePackages + dep, cms/core-cms payload config test assertions, home e2e nav assertion, tsconfig paths, fallow ignoreDependencies entry, anchor-guard FEATURES list, generator e2e strip lists + reference-feature comments (navigation -> auth, incl. feature templates + scaffolding guide), lockfile prune, and feature-list doc trims (CLAUDE.md, AGENTS.md, glossary, app/feature AGENTS.md). Compliance YAML regeneration produced no churn (navigation declared no PII). Cycle break: navigation's UI hooks were the last edge closing the committed core-trpc -> core-api -> navigation -> core-trpc package cycle. With it gone, the lint turbo task graph builds for the first time and every package's ESLint executes; the epic's lint waiver expires here. Latent findings: 3 errors, all mechanical, fixed in-slice - require() import in turbo/generators/config.ts (no-require-imports), literal type assertion in auth's authentication.service.ts (prefer-as-const), and next-env.d.ts triple-slash in apps/cms (rule scoped off for that generated file, mirroring web-next's existing override). 99 warn-severity findings remain across 5 packages (pii-declaration-must-be-complete on test fixtures, turbo/no-undeclared-env-vars on test env keys) - all warn-by-design, non-gating. core-trpc keeps a consumer (apps/web-next providers) and stays per ADR-027. Its unused @trpc/react-query dependency, surfaced by the post-deletion fallow audit, is removed rather than ignore-listed - core-trpc's hooks use @trpc/tanstack-react-query. Remaining fallow warn (auth validateSession "unused member") is a false positive: the method implements IAuthenticationService and is exercised in container.test.ts; auth stays untouched as the regression canary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016j8z4VHjedXDTjEDNg7qHK
This commit is contained in:
@@ -16,7 +16,6 @@
|
||||
- **`@repo/<feature>/api`** subpath exports only (to get tRPC routers)
|
||||
- e.g., `import { authRouter } from "@repo/auth/api"`
|
||||
- e.g., `import { blogRouter } from "@repo/blog/api"`
|
||||
- e.g., `import { navigationRouter } from "@repo/navigation/api"`
|
||||
- `@repo/core-shared/trpc/init` — for `t.router()` builder
|
||||
|
||||
## Must NOT import
|
||||
@@ -28,9 +27,11 @@
|
||||
## Public exports
|
||||
|
||||
From `package.json`:
|
||||
|
||||
- `.` — `appRouter` and `AppRouter` type
|
||||
|
||||
Example usage:
|
||||
|
||||
```typescript
|
||||
import { appRouter, type AppRouter } from "@repo/core-api";
|
||||
```
|
||||
|
||||
@@ -17,7 +17,6 @@
|
||||
"@repo/core-consent": "workspace:*",
|
||||
"@repo/core-dsr": "workspace:*",
|
||||
"@repo/core-shared": "workspace:*",
|
||||
"@repo/navigation": "workspace:*",
|
||||
"@trpc/server": "^11.0.0"
|
||||
},
|
||||
"devDependencies": {
|
||||
|
||||
@@ -1,12 +1,10 @@
|
||||
import { router } from "@repo/core-shared/trpc/init";
|
||||
import { authRouter } from "@repo/auth/api";
|
||||
import { navigationRouter } from "@repo/navigation/api";
|
||||
import { dsrRouter } from "@repo/core-dsr";
|
||||
import { consentRouter } from "@repo/core-consent";
|
||||
|
||||
export const appRouter = router({
|
||||
auth: authRouter,
|
||||
navigation: navigationRouter,
|
||||
// gen:routers — optional-core routers composed below
|
||||
dsr: dsrRouter,
|
||||
consent: consentRouter,
|
||||
|
||||
@@ -65,11 +65,10 @@ function makeUnauthCaller(
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("appRouter composition", () => {
|
||||
it("exposes auth, navigation routers", () => {
|
||||
it("exposes auth router", () => {
|
||||
const procedures = appRouter._def.procedures;
|
||||
const keys = Object.keys(procedures);
|
||||
expect(keys.some((k) => k.startsWith("auth."))).toBe(true);
|
||||
expect(keys.some((k) => k.startsWith("navigation."))).toBe(true);
|
||||
});
|
||||
|
||||
it("exposes dsr and consent routers", () => {
|
||||
|
||||
Reference in New Issue
Block a user