refactor(navigation)!: delete navigation demo feature
Veect retrofit (ADR-027): fifth and final slice of the demo-content removal. Deletes packages/navigation whole and prunes every composition edge in one commit: core-api router mount + dep + router test, core-cms header-global composition + dep + regenerated Payload types (globals now empty), web-next bindAll (prod + dev-seed) + tests + Tailwind source + transpilePackages + dep, cms/core-cms payload config test assertions, home e2e nav assertion, tsconfig paths, fallow ignoreDependencies entry, anchor-guard FEATURES list, generator e2e strip lists + reference-feature comments (navigation -> auth, incl. feature templates + scaffolding guide), lockfile prune, and feature-list doc trims (CLAUDE.md, AGENTS.md, glossary, app/feature AGENTS.md). Compliance YAML regeneration produced no churn (navigation declared no PII). Cycle break: navigation's UI hooks were the last edge closing the committed core-trpc -> core-api -> navigation -> core-trpc package cycle. With it gone, the lint turbo task graph builds for the first time and every package's ESLint executes; the epic's lint waiver expires here. Latent findings: 3 errors, all mechanical, fixed in-slice - require() import in turbo/generators/config.ts (no-require-imports), literal type assertion in auth's authentication.service.ts (prefer-as-const), and next-env.d.ts triple-slash in apps/cms (rule scoped off for that generated file, mirroring web-next's existing override). 99 warn-severity findings remain across 5 packages (pii-declaration-must-be-complete on test fixtures, turbo/no-undeclared-env-vars on test env keys) - all warn-by-design, non-gating. core-trpc keeps a consumer (apps/web-next providers) and stays per ADR-027. Its unused @trpc/react-query dependency, surfaced by the post-deletion fallow audit, is removed rather than ignore-listed - core-trpc's hooks use @trpc/tanstack-react-query. Remaining fallow warn (auth validateSession "unused member") is a false positive: the method implements IAuthenticationService and is exercised in container.test.ts; auth stays untouched as the regression canary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016j8z4VHjedXDTjEDNg7qHK
This commit is contained in:
@@ -63,7 +63,7 @@ describe("e2e: core-package events", () => {
|
||||
|
||||
// Strip @repo/core-events from feature package.json files so pnpm install
|
||||
// succeeds without the package being present (simulating the post-removal state).
|
||||
const featurePackages = ["auth", "navigation"];
|
||||
const featurePackages = ["auth"];
|
||||
for (const pkg of featurePackages) {
|
||||
const pkgJson = join(tmp, "packages", pkg, "package.json");
|
||||
stripCoreEventsDep(pkgJson);
|
||||
|
||||
@@ -63,12 +63,8 @@ describe("e2e: core-package trpc", () => {
|
||||
|
||||
// Strip @repo/core-trpc from every package that references it so pnpm
|
||||
// install succeeds without the package being present (simulating the
|
||||
// post-removal state). Apps list it directly; the navigation feature
|
||||
// depends on it for its ./ui tRPC hooks.
|
||||
for (const pkgDir of [
|
||||
["apps", "web-next"],
|
||||
["packages", "navigation"],
|
||||
]) {
|
||||
// post-removal state). Only apps/web-next lists it directly.
|
||||
for (const pkgDir of [["apps", "web-next"]]) {
|
||||
stripCoreTrpcDep(join(tmp, ...pkgDir, "package.json"));
|
||||
}
|
||||
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { existsSync } from "node:fs";
|
||||
import { existsSync, readFileSync, writeFileSync } from "node:fs";
|
||||
import { join } from "node:path";
|
||||
import type { PlopTypes } from "@turbo/gen";
|
||||
import { assertAnchors } from "./lib/anchor-validate.js";
|
||||
@@ -16,7 +16,7 @@ import { registerFeatureInReleasePlease } from "./lib/release-please-utils.js";
|
||||
* Turbo generator: `feature`
|
||||
*
|
||||
* Scaffolds a feature package under `packages/<name>/`
|
||||
* matching the shape of the existing `navigation` reference feature.
|
||||
* matching the shape of the existing `auth` reference feature.
|
||||
*
|
||||
* Scope (intentionally limited):
|
||||
* - Single entity, single use case (`getX`)
|
||||
@@ -1108,12 +1108,11 @@ function readerActions(a: { feature: string }): PlopTypes.ActionType[] {
|
||||
},
|
||||
// Add ./reader subpath to package.json exports map
|
||||
() => {
|
||||
const fs = require("node:fs");
|
||||
const pkgPath = join(process.cwd(), pkgJsonPath);
|
||||
const pkg = JSON.parse(fs.readFileSync(pkgPath, "utf8"));
|
||||
const pkg = JSON.parse(readFileSync(pkgPath, "utf8"));
|
||||
if (!pkg.exports) pkg.exports = {};
|
||||
pkg.exports["./reader"] = "./src/integrations/readers/index.ts";
|
||||
fs.writeFileSync(pkgPath, JSON.stringify(pkg, null, 2) + "\n");
|
||||
writeFileSync(pkgPath, JSON.stringify(pkg, null, 2) + "\n");
|
||||
return `Added "./reader" export to ${pkgJsonPath}`;
|
||||
},
|
||||
() => printReaderNextSteps(a),
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
// Phase-1 stub. Replace with `defineFactory<{{pascalCase entity}}>` once the
|
||||
// entity shape stabilises. See packages/navigation/src/__factories__/ for an
|
||||
// entity shape stabilises. See packages/auth/src/__factories__/ for an
|
||||
// example.
|
||||
export {};
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// Payload CMS integration barrel for @repo/{{kebabCase name}}.
|
||||
// Re-export this feature's collections and globals here as you add them
|
||||
// under ./collections and ./globals. See packages/navigation/src/integrations/cms
|
||||
// under ./collections and ./globals. See packages/auth/src/integrations/cms
|
||||
// for the canonical shape. The `<gen:job-tasks>` anchor below is required by
|
||||
// `pnpm turbo gen job` and `pnpm turbo gen event` — do not remove it.
|
||||
export {};
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
// Phase-1 placeholder. Re-export React Query option builders here once you
|
||||
// add `ui/query.ts`. See packages/navigation/src/ui/index.ts for the
|
||||
// add `ui/query.ts`. See packages/auth/src/ui/index.ts for the
|
||||
// canonical shape.
|
||||
export {};
|
||||
|
||||
Reference in New Issue
Block a user