fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat(marketing-pages): bind binders accept (realtime, realtimeRegistry) params

Browse Source 
Extend bindProductionMarketingPages and bindDevSeedMarketingPages to 7-arg signatures.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Danijel Martinek
2026-05-08 22:41:13 +02:00
parent f85b0891ee
commit 579c5911fd
4 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/marketing-pages/package.json
View File

@@ -24,6 +24,7 @@
"dependencies": { "dependencies": {
"@repo/auth": "workspace:*", "@repo/auth": "workspace:*",
"@repo/core-events": "workspace:*", "@repo/core-events": "workspace:*",
"@repo/core-realtime": "workspace:*",
"@repo/core-shared": "workspace:*", "@repo/core-shared": "workspace:*",
"@trpc/server": "^11.0.0", "@trpc/server": "^11.0.0",
"inversify": "^6.2.0", "inversify": "^6.2.0",

11
packages/marketing-pages/src/di/bind-dev-seed.test.ts
View File

@@ -1,7 +1,8 @@
import "reflect-metadata"; import "reflect-metadata";
import { afterEach, beforeEach, describe, expect, it } from "vitest"; import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { NoopTracer, NoopLogger } from "@repo/core-shared/instrumentation"; import { NoopTracer, NoopLogger } from "@repo/core-shared/instrumentation";
import { RecordingEventBus, RecordingJobQueue } from "@repo/core-testing/instrumentation"; import { RecordingEventBus, RecordingJobQueue, RecordingRealtimeBroadcaster } from "@repo/core-testing/instrumentation";
import { RealtimeHandlerRegistry } from "@repo/core-realtime";
import { bindDevSeedMarketingPages } from "@/di/bind-dev-seed"; import { bindDevSeedMarketingPages } from "@/di/bind-dev-seed";
import { marketingPagesContainer } from "@/di/container"; import { marketingPagesContainer } from "@/di/container";
import { MARKETING_PAGES_SYMBOLS } from "@/di/symbols"; import { MARKETING_PAGES_SYMBOLS } from "@/di/symbols";
@@ -60,7 +61,7 @@ describe("bindDevSeedMarketingPages", () => {
}); });
it("populates the pages repository with the dev pages", async () => { it("populates the pages repository with the dev pages", async () => {
await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue()); await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue(), new RecordingRealtimeBroadcaster(), new RealtimeHandlerRegistry());
const repo = marketingPagesContainer.get<IPagesRepository>( const repo = marketingPagesContainer.get<IPagesRepository>(
MARKETING_PAGES_SYMBOLS.IPagesRepository, MARKETING_PAGES_SYMBOLS.IPagesRepository,
@@ -71,7 +72,7 @@ describe("bindDevSeedMarketingPages", () => {
}); });
it("seeds site settings with a non-default site name", async () => { it("seeds site settings with a non-default site name", async () => {
await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue()); await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue(), new RecordingRealtimeBroadcaster(), new RealtimeHandlerRegistry());
const settingsRepo = marketingPagesContainer.get<ISiteSettingsRepository>( const settingsRepo = marketingPagesContainer.get<ISiteSettingsRepository>(
MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository, MARKETING_PAGES_SYMBOLS.ISiteSettingsRepository,
@@ -83,13 +84,13 @@ describe("bindDevSeedMarketingPages", () => {
}); });
it("is idempotent — calling twice rebuilds fresh populated repos", async () => { it("is idempotent — calling twice rebuilds fresh populated repos", async () => {
await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue()); await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue(), new RecordingRealtimeBroadcaster(), new RealtimeHandlerRegistry());
const before = marketingPagesContainer.get<IPagesRepository>( const before = marketingPagesContainer.get<IPagesRepository>(
MARKETING_PAGES_SYMBOLS.IPagesRepository, MARKETING_PAGES_SYMBOLS.IPagesRepository,
); );
const beforeCount = (await before.getPages()).length; const beforeCount = (await before.getPages()).length;
await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue()); await bindDevSeedMarketingPages(noop.tracer, noop.logger, new RecordingEventBus(), new RecordingJobQueue(), new RecordingRealtimeBroadcaster(), new RealtimeHandlerRegistry());
const after = marketingPagesContainer.get<IPagesRepository>( const after = marketingPagesContainer.get<IPagesRepository>(
MARKETING_PAGES_SYMBOLS.IPagesRepository, MARKETING_PAGES_SYMBOLS.IPagesRepository,
); );

5
packages/marketing-pages/src/di/bind-dev-seed.ts
View File

@@ -6,6 +6,7 @@ import {
type ILogger, type ILogger,
} from "@repo/core-shared/instrumentation"; } from "@repo/core-shared/instrumentation";
import type { IEventBus } from "@repo/core-events"; import type { IEventBus } from "@repo/core-events";
import type { IRealtimeBroadcaster, IRealtimeHandlerRegistry } from "@repo/core-realtime";
import type { IJobQueue } from "@repo/core-shared/jobs"; import type { IJobQueue } from "@repo/core-shared/jobs";
import { marketingPagesContainer } from "./container.js"; import { marketingPagesContainer } from "./container.js";
import { MARKETING_PAGES_SYMBOLS } from "./symbols.js"; import { MARKETING_PAGES_SYMBOLS } from "./symbols.js";
@@ -38,6 +39,8 @@ export async function bindDevSeedMarketingPages(
logger: ILogger, logger: ILogger,
bus: IEventBus, bus: IEventBus,
queue: IJobQueue, queue: IJobQueue,
realtime: IRealtimeBroadcaster,
realtimeRegistry: IRealtimeHandlerRegistry,
): Promise<void> { ): Promise<void> {
// Bind shared instrumentation into feature container // Bind shared instrumentation into feature container
if (marketingPagesContainer.isBound(INSTRUMENTATION_SYMBOLS.TRACER)) { if (marketingPagesContainer.isBound(INSTRUMENTATION_SYMBOLS.TRACER)) {
@@ -193,5 +196,7 @@ export async function bindDevSeedMarketingPages(
}, },
); );
} }
void realtime;
void realtimeRegistry;
// <gen:realtime-handlers> // <gen:realtime-handlers>
} }

5
packages/marketing-pages/src/di/bind-production.ts
View File

@@ -7,6 +7,7 @@ import {
type ILogger, type ILogger,
} from "@repo/core-shared/instrumentation"; } from "@repo/core-shared/instrumentation";
import type { IEventBus } from "@repo/core-events"; import type { IEventBus } from "@repo/core-events";
import type { IRealtimeBroadcaster, IRealtimeHandlerRegistry } from "@repo/core-realtime";
import type { IJobQueue } from "@repo/core-shared/jobs"; import type { IJobQueue } from "@repo/core-shared/jobs";
import { marketingPagesContainer } from "./container"; import { marketingPagesContainer } from "./container";
import { MARKETING_PAGES_SYMBOLS } from "./symbols"; import { MARKETING_PAGES_SYMBOLS } from "./symbols";
@@ -28,6 +29,8 @@ export function bindProductionMarketingPages(
logger: ILogger, logger: ILogger,
bus: IEventBus, bus: IEventBus,
queue: IJobQueue, queue: IJobQueue,
realtime: IRealtimeBroadcaster,
realtimeRegistry: IRealtimeHandlerRegistry,
): void { ): void {
// Bind shared instrumentation into feature container // Bind shared instrumentation into feature container
if (marketingPagesContainer.isBound(INSTRUMENTATION_SYMBOLS.TRACER)) { if (marketingPagesContainer.isBound(INSTRUMENTATION_SYMBOLS.TRACER)) {
@@ -171,5 +174,7 @@ export function bindProductionMarketingPages(
marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.ISendWelcomeEmailJob); marketingPagesContainer.unbind(MARKETING_PAGES_SYMBOLS.ISendWelcomeEmailJob);
} }
marketingPagesContainer.bind(MARKETING_PAGES_SYMBOLS.ISendWelcomeEmailJob).toConstantValue(wrappedSendWelcomeEmail); marketingPagesContainer.bind(MARKETING_PAGES_SYMBOLS.ISendWelcomeEmailJob).toConstantValue(wrappedSendWelcomeEmail);
void realtime;
void realtimeRegistry;
// <gen:realtime-handlers> // <gen:realtime-handlers>
} }