fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor(auth): factory-style use cases + controllers + real Payload impls

Browse Source 
- Use cases (sign-in, sign-up, sign-out) → factory functions with I*UseCase aliases
- Controllers → factory functions with I*Controller aliases
- DI symbols + module updated with .toDynamicValue() bindings for factories
- New: real UsersRepository (Payload-backed, SanitizedConfig, contract-tested)
- New: real AuthenticationService (node:crypto hashing/UUIDs; createSession/
  validateSession/invalidateSession deferred — see refactor log §7)
- bindProductionAuth swaps both mocks for real impls (was a no-op before)
- Tests refactored to construct mocks and inject directly (no container rebinding)
- Feature test constructs full chain via direct factory injection

Refactor log: §2, §4.1, §4.2, §5.1, §5.2, §6.1, §7
Spec: §6.1, §7

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Danijel Martinek
2026-05-06 00:01:11 +02:00
parent aa325f91cc
commit 780d5cb83b
24 changed files with 694 additions and 349 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
packages/auth/tests/sign-in-flow.feature.test.ts
View File

@@ -1,36 +1,27 @@
// Feature-level test: sign-up, then sign-in with the new credentials, then sign-out.
// Constructs the full chain via direct injection (no container rebinding).
import { beforeEach, describe, expect, it } from "vitest";
import { authContainer } from "../src/di/container";
import { AUTH_SYMBOLS } from "../src/di/symbols";
import { describe, it, expect } from "vitest";
import { MockUsersRepository } from "../src/infrastructure/repositories/users.repository.mock";
import { MockAuthenticationService } from "../src/infrastructure/services/authentication.service.mock";
import type { IUsersRepository } from "../src/application/repositories/users.repository.interface";
import type { IAuthenticationService } from "../src/application/services/authentication.service.interface";
import { authRouter } from "../src/integrations/api/router";
import { signInUseCase } from "../src/application/use-cases/sign-in.use-case";
import { signUpUseCase } from "../src/application/use-cases/sign-up.use-case";
import { signOutUseCase } from "../src/application/use-cases/sign-out.use-case";
import { signInController } from "../src/interface-adapters/controllers/sign-in.controller";
import { signUpController } from "../src/interface-adapters/controllers/sign-up.controller";
import { signOutController } from "../src/interface-adapters/controllers/sign-out.controller";
describe("auth feature: sign-up → sign-in → sign-out", () => {
beforeEach(() => {
if (authContainer.isBound(AUTH_SYMBOLS.IUsersRepository)) {
authContainer.unbind(AUTH_SYMBOLS.IUsersRepository);
}
if (authContainer.isBound(AUTH_SYMBOLS.IAuthenticationService)) {
authContainer.unbind(AUTH_SYMBOLS.IAuthenticationService);
}
const usersRepo = new MockUsersRepository();
const authService = new MockAuthenticationService(usersRepo);
authContainer
.bind<IUsersRepository>(AUTH_SYMBOLS.IUsersRepository)
.toConstantValue(usersRepo);
authContainer
.bind<IAuthenticationService>(AUTH_SYMBOLS.IAuthenticationService)
.toConstantValue(authService);
});
it("a new user can sign up, then sign in, then sign out", async () => {
const caller = authRouter.createCaller({});
// Construct the full chain via direct injection
const users = new MockUsersRepository([]);
const auth = new MockAuthenticationService(users);
const signUpResult = await caller.signUp({
const signIn = signInController(signInUseCase(users, auth));
const signUp = signUpController(signUpUseCase(users, auth));
const signOut = signOutController(signOutUseCase(auth));
const signUpResult = await signUp({
username: "newperson",
password: "verysecret",
confirmPassword: "verysecret",
@@ -38,15 +29,13 @@ describe("auth feature: sign-up → sign-in → sign-out", () => {
expect(signUpResult.user.username).toBe("newperson");
const userId = signUpResult.user.id;
const signInCookie = await caller.signIn({
const signInCookie = await signIn({
username: "newperson",
password: "verysecret",
});
expect(signInCookie.value).toBe("session_" + userId);
const signOutResult = await caller.signOut({
sessionId: signInCookie.value,
});
const signOutResult = await signOut(signInCookie.value);
expect(signOutResult.value).toBe("");
});
});