fix(features): address Task 3 code review feedback

- Add navItemFactory to navigation (spec §5.1 — was missing)
- Refactor blog/router.test.ts to use articleFactory (eliminate new Date())
- headerFactory uses sequence for logoId (deterministic buildList output)
- Align media/tsconfig.json with other features (jsx + tests/ include)
- Refactor auth/container.test.ts to use userFactory

Reviewer: superpowers:code-reviewer (Task 3 of Plan 7).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-05-05 15:18:35 +02:00
parent 53c2fbb9e1
commit a74f217703
8 changed files with 57 additions and 19 deletions

View File

@@ -7,7 +7,7 @@ describe("headerFactory", () => {
it("returns a Header with stable defaults", () => {
const h = headerFactory.build();
expect(h.items).toHaveLength(0);
expect(h.logoId).toBeUndefined();
expect(h.logoId).toBe("logo-1");
});
it("applies overrides", () => {
@@ -26,4 +26,11 @@ describe("headerFactory", () => {
expect(a.items).toHaveLength(1);
expect(b.items).toHaveLength(0);
});
it("logoId reflects sequence for deterministic buildList output", () => {
const first = headerFactory.build();
const second = headerFactory.build();
expect(first.logoId).toBe("logo-1");
expect(second.logoId).toBe("logo-2");
});
});

View File

@@ -1,6 +1,7 @@
import { defineFactory } from "@repo/core-testing/factory";
import type { Header } from "../entities/header.js";
export const headerFactory = defineFactory<Header>(() => ({
export const headerFactory = defineFactory<Header>(({ sequence }) => ({
logoId: `logo-${sequence}`,
items: [],
}));

View File

@@ -1 +1,2 @@
export { headerFactory } from "./header.factory.js";
export { navItemFactory } from "./nav-item.factory.js";

View File

@@ -0,0 +1,29 @@
import { describe, it, expect, beforeEach } from "vitest";
import { navItemFactory } from "@/__factories__/nav-item.factory";
describe("navItemFactory", () => {
beforeEach(() => navItemFactory.reset());
it("returns a HeaderItem with stable defaults", () => {
const item = navItemFactory.build();
expect(item.label).toBe("Item 1");
expect(item.href).toBe("/item-1");
expect(item.external).toBe(false);
});
it("applies overrides", () => {
const item = navItemFactory.build({ label: "Home", href: "/", external: true });
expect(item.label).toBe("Home");
expect(item.href).toBe("/");
expect(item.external).toBe(true);
});
it("increments sequence per build", () => {
const a = navItemFactory.build();
const b = navItemFactory.build();
expect(a.label).toBe("Item 1");
expect(b.label).toBe("Item 2");
expect(a.href).toBe("/item-1");
expect(b.href).toBe("/item-2");
});
});

View File

@@ -0,0 +1,8 @@
import { defineFactory } from "@repo/core-testing/factory";
import type { HeaderItem } from "../entities/header.js";
export const navItemFactory = defineFactory<HeaderItem>(({ sequence }) => ({
label: `Item ${sequence}`,
href: `/item-${sequence}`,
external: false,
}));