fix(features): address Task 3 code review feedback
- Add navItemFactory to navigation (spec §5.1 — was missing) - Refactor blog/router.test.ts to use articleFactory (eliminate new Date()) - headerFactory uses sequence for logoId (deterministic buildList output) - Align media/tsconfig.json with other features (jsx + tests/ include) - Refactor auth/container.test.ts to use userFactory Reviewer: superpowers:code-reviewer (Task 3 of Plan 7). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -7,7 +7,7 @@ describe("headerFactory", () => {
|
||||
it("returns a Header with stable defaults", () => {
|
||||
const h = headerFactory.build();
|
||||
expect(h.items).toHaveLength(0);
|
||||
expect(h.logoId).toBeUndefined();
|
||||
expect(h.logoId).toBe("logo-1");
|
||||
});
|
||||
|
||||
it("applies overrides", () => {
|
||||
@@ -26,4 +26,11 @@ describe("headerFactory", () => {
|
||||
expect(a.items).toHaveLength(1);
|
||||
expect(b.items).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("logoId reflects sequence for deterministic buildList output", () => {
|
||||
const first = headerFactory.build();
|
||||
const second = headerFactory.build();
|
||||
expect(first.logoId).toBe("logo-1");
|
||||
expect(second.logoId).toBe("logo-2");
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user