fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

feat(media): wire instrumentation — media repo spans + getMedia/listMedia/deleteMedia withSpan

Browse Source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Danijel Martinek
2026-05-07 18:01:46 +02:00
parent e14a23dccd
commit a943f95929
8 changed files with 395 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/media/src/di/bind-dev-seed.test.ts
View File

@@ -1,11 +1,14 @@
import "reflect-metadata";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { NoopTracer, NoopLogger } from "@repo/core-shared/instrumentation";
import { bindDevSeedMedia } from "@/di/bind-dev-seed";
import { mediaContainer } from "@/di/container";
import { MEDIA_SYMBOLS } from "@/di/symbols";
import { MockMediaRepository } from "@/infrastructure/repositories/media.repository.mock";
import type { IMediaRepository } from "@/application/repositories/media.repository.interface";
const noop = { tracer: new NoopTracer(), logger: new NoopLogger() };
describe("bindDevSeedMedia", () => {
// Each test starts from the default empty-mock binding and tears down
// afterwards so the global mediaContainer state stays clean for siblings.
@@ -28,7 +31,7 @@ describe("bindDevSeedMedia", () => {
});
it("populates the repository with the dev media entries", async () => {
await bindDevSeedMedia();
await bindDevSeedMedia(noop.tracer, noop.logger);
const repo = mediaContainer.get<IMediaRepository>(
MEDIA_SYMBOLS.IMediaRepository,
@@ -39,7 +42,7 @@ describe("bindDevSeedMedia", () => {
});
it("seeds placeholder-1 reachable by id", async () => {
await bindDevSeedMedia();
await bindDevSeedMedia(noop.tracer, noop.logger);
const repo = mediaContainer.get<IMediaRepository>(
MEDIA_SYMBOLS.IMediaRepository,
@@ -52,13 +55,13 @@ describe("bindDevSeedMedia", () => {
});
it("is idempotent — calling twice rebuilds a fresh populated repo", async () => {
await bindDevSeedMedia();
await bindDevSeedMedia(noop.tracer, noop.logger);
const before = mediaContainer.get<IMediaRepository>(
MEDIA_SYMBOLS.IMediaRepository,
);
const beforeCount = (await before.listMedia()).length;
await bindDevSeedMedia();
await bindDevSeedMedia(noop.tracer, noop.logger);
const after = mediaContainer.get<IMediaRepository>(
MEDIA_SYMBOLS.IMediaRepository,
);

85
packages/media/src/di/bind-dev-seed.ts
View File

@@ -1,7 +1,19 @@
import {
withSpan,
INSTRUMENTATION_SYMBOLS,
type ITracer,
type ILogger,
} from "@repo/core-shared/instrumentation";
import { mediaContainer } from "./container.js";
import { MEDIA_SYMBOLS } from "./symbols.js";
import { MockMediaRepository } from "../infrastructure/repositories/media.repository.mock.js";
import { buildDevMedia } from "../__seeds__/dev.js";
import { getMediaUseCase } from "../application/use-cases/get-media.use-case.js";
import { listMediaUseCase } from "../application/use-cases/list-media.use-case.js";
import { deleteMediaUseCase } from "../application/use-cases/delete-media.use-case.js";
import { getMediaController } from "../interface-adapters/controllers/get-media.controller.js";
import { listMediaController } from "../interface-adapters/controllers/list-media.controller.js";
import { deleteMediaController } from "../interface-adapters/controllers/delete-media.controller.js";
import type { IMediaRepository } from "../application/repositories/media.repository.interface.js";
/**
@@ -14,12 +26,22 @@ import type { IMediaRepository } from "../application/repositories/media.reposit
* Idempotent: safe to call multiple times; each call rebuilds a fresh
* populated repo and rebinds the symbol.
*/
export async function bindDevSeedMedia(): Promise<void> {
export async function bindDevSeedMedia(tracer: ITracer, logger: ILogger): Promise<void> {
// Bind shared instrumentation into feature container
if (mediaContainer.isBound(INSTRUMENTATION_SYMBOLS.TRACER)) {
mediaContainer.unbind(INSTRUMENTATION_SYMBOLS.TRACER);
}
if (mediaContainer.isBound(INSTRUMENTATION_SYMBOLS.LOGGER)) {
mediaContainer.unbind(INSTRUMENTATION_SYMBOLS.LOGGER);
}
mediaContainer.bind<ITracer>(INSTRUMENTATION_SYMBOLS.TRACER).toConstantValue(tracer);
mediaContainer.bind<ILogger>(INSTRUMENTATION_SYMBOLS.LOGGER).toConstantValue(logger);
if (mediaContainer.isBound(MEDIA_SYMBOLS.IMediaRepository)) {
mediaContainer.unbind(MEDIA_SYMBOLS.IMediaRepository);
}
const repo = new MockMediaRepository();
const repo = new MockMediaRepository(tracer, logger);
for (const media of buildDevMedia()) {
await repo._store(media);
}
@@ -27,4 +49,63 @@ export async function bindDevSeedMedia(): Promise<void> {
mediaContainer
.bind<IMediaRepository>(MEDIA_SYMBOLS.IMediaRepository)
.toConstantValue(repo);
// Wrap use cases + controllers identically to bind-production
const wrappedGetMedia = withSpan(
tracer,
{ name: "media.getMedia", op: "use-case" },
getMediaUseCase(repo),
);
const wrappedListMedia = withSpan(
tracer,
{ name: "media.listMedia", op: "use-case" },
listMediaUseCase(repo),
);
const wrappedDeleteMedia = withSpan(
tracer,
{ name: "media.deleteMedia", op: "use-case" },
deleteMediaUseCase(repo),
);
for (const sym of [
MEDIA_SYMBOLS.IGetMediaUseCase,
MEDIA_SYMBOLS.IListMediaUseCase,
MEDIA_SYMBOLS.IDeleteMediaUseCase,
MEDIA_SYMBOLS.IGetMediaController,
MEDIA_SYMBOLS.IListMediaController,
MEDIA_SYMBOLS.IDeleteMediaController,
]) {
if (mediaContainer.isBound(sym)) mediaContainer.unbind(sym);
}
mediaContainer.bind(MEDIA_SYMBOLS.IGetMediaUseCase).toConstantValue(wrappedGetMedia);
mediaContainer.bind(MEDIA_SYMBOLS.IListMediaUseCase).toConstantValue(wrappedListMedia);
mediaContainer.bind(MEDIA_SYMBOLS.IDeleteMediaUseCase).toConstantValue(wrappedDeleteMedia);
mediaContainer
.bind(MEDIA_SYMBOLS.IGetMediaController)
.toConstantValue(
withSpan(
tracer,
{ name: "media.getMedia", op: "controller" },
getMediaController(wrappedGetMedia),
),
);
mediaContainer
.bind(MEDIA_SYMBOLS.IListMediaController)
.toConstantValue(
withSpan(
tracer,
{ name: "media.listMedia", op: "controller" },
listMediaController(wrappedListMedia),
),
);
mediaContainer
.bind(MEDIA_SYMBOLS.IDeleteMediaController)
.toConstantValue(
withSpan(
tracer,
{ name: "media.deleteMedia", op: "controller" },
deleteMediaController(wrappedDeleteMedia),
),
);
}

96
packages/media/src/di/bind-production.ts
View File

@@ -1,13 +1,105 @@
import type { SanitizedConfig } from "payload";
import {
withSpan,
INSTRUMENTATION_SYMBOLS,
type ITracer,
type ILogger,
} from "@repo/core-shared/instrumentation";
import { mediaContainer } from "./container";
import { MEDIA_SYMBOLS } from "./symbols";
import { MediaRepository } from "../infrastructure/repositories/media.repository";
import { getMediaUseCase } from "../application/use-cases/get-media.use-case";
import { listMediaUseCase } from "../application/use-cases/list-media.use-case";
import { deleteMediaUseCase } from "../application/use-cases/delete-media.use-case";
import { getMediaController } from "../interface-adapters/controllers/get-media.controller";
import { listMediaController } from "../interface-adapters/controllers/list-media.controller";
import { deleteMediaController } from "../interface-adapters/controllers/delete-media.controller";
export function bindProductionMedia(config: SanitizedConfig): void {
export function bindProductionMedia(
config: SanitizedConfig,
tracer: ITracer,
logger: ILogger,
): void {
// Bind shared instrumentation into feature container
if (mediaContainer.isBound(INSTRUMENTATION_SYMBOLS.TRACER)) {
mediaContainer.unbind(INSTRUMENTATION_SYMBOLS.TRACER);
}
if (mediaContainer.isBound(INSTRUMENTATION_SYMBOLS.LOGGER)) {
mediaContainer.unbind(INSTRUMENTATION_SYMBOLS.LOGGER);
}
mediaContainer.bind<ITracer>(INSTRUMENTATION_SYMBOLS.TRACER).toConstantValue(tracer);
mediaContainer.bind<ILogger>(INSTRUMENTATION_SYMBOLS.LOGGER).toConstantValue(logger);
// Real repository
if (mediaContainer.isBound(MEDIA_SYMBOLS.IMediaRepository)) {
mediaContainer.unbind(MEDIA_SYMBOLS.IMediaRepository);
}
const repo = new MediaRepository(config, tracer, logger);
mediaContainer
.bind(MEDIA_SYMBOLS.IMediaRepository)
.toConstantValue(new MediaRepository(config));
.toConstantValue(repo);
// Use cases — wrapped with span at bind time
const wrappedGetMedia = withSpan(
tracer,
{ name: "media.getMedia", op: "use-case" },
getMediaUseCase(repo),
);
const wrappedListMedia = withSpan(
tracer,
{ name: "media.listMedia", op: "use-case" },
listMediaUseCase(repo),
);
const wrappedDeleteMedia = withSpan(
tracer,
{ name: "media.deleteMedia", op: "use-case" },
deleteMediaUseCase(repo),
);
for (const sym of [
MEDIA_SYMBOLS.IGetMediaUseCase,
MEDIA_SYMBOLS.IListMediaUseCase,
MEDIA_SYMBOLS.IDeleteMediaUseCase,
]) {
if (mediaContainer.isBound(sym)) mediaContainer.unbind(sym);
}
mediaContainer.bind(MEDIA_SYMBOLS.IGetMediaUseCase).toConstantValue(wrappedGetMedia);
mediaContainer.bind(MEDIA_SYMBOLS.IListMediaUseCase).toConstantValue(wrappedListMedia);
mediaContainer.bind(MEDIA_SYMBOLS.IDeleteMediaUseCase).toConstantValue(wrappedDeleteMedia);
// Controllers — wrapped with span at bind time
for (const sym of [
MEDIA_SYMBOLS.IGetMediaController,
MEDIA_SYMBOLS.IListMediaController,
MEDIA_SYMBOLS.IDeleteMediaController,
]) {
if (mediaContainer.isBound(sym)) mediaContainer.unbind(sym);
}
mediaContainer
.bind(MEDIA_SYMBOLS.IGetMediaController)
.toConstantValue(
withSpan(
tracer,
{ name: "media.getMedia", op: "controller" },
getMediaController(wrappedGetMedia),
),
);
mediaContainer
.bind(MEDIA_SYMBOLS.IListMediaController)
.toConstantValue(
withSpan(
tracer,
{ name: "media.listMedia", op: "controller" },
listMediaController(wrappedListMedia),
),
);
mediaContainer
.bind(MEDIA_SYMBOLS.IDeleteMediaController)
.toConstantValue(
withSpan(
tracer,
{ name: "media.deleteMedia", op: "controller" },
deleteMediaController(wrappedDeleteMedia),
),
);
}