feat(coverage): pnpm coverage:aggregate + L2 implementation
Lands L2 of the agent-first coverage architecture (ADR-020) — the
aggregated trend store.
Script: scripts/coverage/aggregate.mjs (zero-dep Node ESM)
- discoverLcovs: walks packages/* and apps/* for coverage/lcov.info
- normalizeLcov: rewrites SF entries from package-relative (vitest's
output) to repo-relative, so the merged file matches git diff paths
- summarizeLcov: computes statement/branch/function/line percentages
from LF/LH/BRF/BRH/FNF/FNH summary records
- aggregate: merges all lcovs and returns mergedLcov + summary
- Writes coverage/lcov.info (gitignored — large) and
coverage/summary.json (committed — trend via git log -- ...) with
timestamp, short commit SHA, repo + per-package percentages
Test surface: scripts/coverage/aggregate.test.mjs (10 tests, all green)
- Fixtures at __fixtures__/aggregate-pkg-a.lcov +
aggregate-pkg-b.lcov (synthetic, structured to make percentages
deterministic)
- Covers: path normalization (prefix, absolute, double-prefix
avoidance), summary computation (percentages, zero-division,
rounding), discovery (packages + apps, missing dirs), full
aggregation in a tmp repo
Wired:
- root package.json adds "coverage:aggregate" script
- .gitignore restructured: per-package coverage/ stays ignored,
aggregated /coverage/ ignored EXCEPT summary.json (committed for
trend) and .gitkeep markers
L1 allowlist fix folded in (scripts/coverage/diff.mjs):
- The previous (^|/)coverage/ regex accidentally caught
scripts/coverage/* — replaced with anchored patterns
(^coverage/, ^packages/*/coverage/, ^apps/*/coverage/)
- Allowlist scripts/ and turbo/generators/ since they're dev tooling
tested via node --test, outside vitest's v8 lcov pipeline
Smoke-tested end-to-end:
- pnpm coverage:aggregate merged 3 lcovs (auth + media + navigation
from this session's earlier runs), repo coverage 95.22% statements
- pnpm coverage:diff against HEAD~1 with the new merged lcov reports
PASS — all 6 diff files correctly allowlisted
First committed snapshot of coverage/summary.json lands with this
commit, anchoring the trend history at this state.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -50,6 +50,10 @@ const ALLOWED_GLOBS = [
|
||||
// Shell scripts (not Vitest-covered)
|
||||
/\.sh$/,
|
||||
/\.bash$/,
|
||||
// Dev-tooling scripts — tested via `node --test`, outside vitest's v8 lcov.
|
||||
// (Their own test coverage is gated separately via the scripts' own tests.)
|
||||
/^scripts\//,
|
||||
/^turbo\/generators\//,
|
||||
// Per-package coverage excludes (mirror vitest config)
|
||||
/\/di\/bind-production\.ts$/,
|
||||
/\/application\/repositories\//,
|
||||
@@ -66,7 +70,10 @@ const ALLOWED_GLOBS = [
|
||||
/(^|\/)\.next\//,
|
||||
/(^|\/)\.turbo\//,
|
||||
/(^|\/)node_modules\//,
|
||||
/(^|\/)coverage\//,
|
||||
// Coverage output (anchored to package/app/root, NOT scripts/coverage/)
|
||||
/^coverage\//,
|
||||
/^packages\/[^/]+\/coverage\//,
|
||||
/^apps\/[^/]+\/coverage\//,
|
||||
];
|
||||
|
||||
function isAllowed(file) {
|
||||
|
||||
Reference in New Issue
Block a user