Danijel Martinek
a98e41d080
Three issues uncovered by the full pnpm typecheck/test/boundaries pass
and resolved here:
- core-testing was importing IEventBus / IJobQueue from core-events /
core-shared, creating two boundary violations (tooling → core) and a
build-graph cycle. Inlined the type aliases (mirroring how
RecordingTracer / RecordingLogger handle ITracer / ILogger).
recording-event-bus.test.ts replaces defineEvent() with an inline
descriptor literal so no runtime import is needed either. core-events
and core-shared are removed from core-testing dependencies.
- turbo.json: typecheck and test no longer dependsOn ^typecheck / ^build.
Each package's tsc / vitest resolves cross-package types via
node_modules independently, and dropping the topological dep avoids the
spurious cycle warning that appeared once core-testing started
importing core-events / core-shared.
- turbo.json: feature.dependencies.allow gains "feature". Cross-feature
event flow (ADR-015) requires a consumer feature to import the
publisher's event contract directly. The dangerous form (importing
the publisher's handler/use-case/repo) is still blocked by E1's
no-handler-reexport ESLint rule and the missing public exports.
- TaskConfig<"slug-string"> → TaskConfig<{ input; output }> in the gen
job task template (and the shipped send-welcome-email.task.ts) since
runtime-generated slugs aren't keys of TypedJobs['tasks'].
48 lines
1.5 KiB
TypeScript
48 lines
1.5 KiB
TypeScript
// Local type aliases matching the contracts in @repo/core-events.
|
|
// Kept inline to avoid a build-graph cycle between core-testing and core-events
|
|
// (mirrors the recording-tracer / recording-logger pattern).
|
|
import type { z } from "zod";
|
|
|
|
type EventDescriptor<TName extends string, TSchema extends z.ZodType> = {
|
|
readonly name: TName;
|
|
readonly schema: TSchema;
|
|
};
|
|
|
|
type EventHandler<T> = (event: T) => Promise<void>;
|
|
|
|
interface IEventBus {
|
|
publish<T>(
|
|
descriptor: EventDescriptor<string, z.ZodType<T>>,
|
|
payload: T,
|
|
): Promise<void>;
|
|
subscribe<T>(
|
|
descriptor: EventDescriptor<string, z.ZodType<T>>,
|
|
consumerFeature: string,
|
|
handler: EventHandler<T>,
|
|
): void;
|
|
}
|
|
|
|
export class RecordingEventBus implements IEventBus {
|
|
readonly published: { name: string; payload: unknown }[] = [];
|
|
private readonly handlers = new Map<string, EventHandler<unknown>[]>();
|
|
|
|
async publish<T>(
|
|
descriptor: EventDescriptor<string, z.ZodType<T>>,
|
|
payload: T,
|
|
): Promise<void> {
|
|
descriptor.schema.parse(payload);
|
|
this.published.push({ name: descriptor.name, payload });
|
|
for (const h of this.handlers.get(descriptor.name) ?? []) await h(payload);
|
|
}
|
|
|
|
subscribe<T>(
|
|
descriptor: EventDescriptor<string, z.ZodType<T>>,
|
|
_consumerFeature: string,
|
|
handler: EventHandler<T>,
|
|
): void {
|
|
const arr = this.handlers.get(descriptor.name) ?? [];
|
|
arr.push(handler as EventHandler<unknown>);
|
|
this.handlers.set(descriptor.name, arr);
|
|
}
|
|
}
|