Danijel Martinek
f0775d6ecc
Plan 10 documented R44 (capture at originating-throw layer) but only the R43 repo leg was wired. captureException had zero call sites in any controller or use-case body. This commit closes the gap. Mechanism: - Extract __sentryReported flag helpers into core-shared/instrumentation/ reported-flag.ts. SentryLogger switches to importing them; RecordingLogger carries an inlined copy (tooling → core boundary disallows the import). - Add withCapture(logger, tags, fn) higher-order wrapper paralleling withSpan. On throw: capture-with-tags, mark, re-throw. Bail if the flag was already set — covers the bubbled-from-repo case so each error surfaces in the logger exactly once with the inner-most layer's tags. - Apply withSpan(withCapture(factory)) in every feature's bind-production and bind-dev-seed: auth (3 use cases × 3 controllers), blog (3×3), marketing-pages (2×2), navigation (1×1), media (3×3). Span is outermost so the errored span timing reflects the capture-and-rethrow. - RecordingLogger.captureException now also honours the flag — test capture counts stay honest when both repo and outer layer wrap. Tests: - packages/core-shared/src/instrumentation/with-capture.test.ts — 4 cases covering success, capture-on-throw, mark-on-capture, no-double via the flag. - packages/blog/tests/r44-no-double-capture.test.ts — 3 cases: repo throw → 1 capture with repo tags; controller parse fail → 1 capture with controller tags; success → 0 captures. Verification: pnpm test 26/26, pnpm lint 15/15, pnpm typecheck 14/14. Docs: ADR-014 and the refactor log gain a "Post-merge follow-up" section recording the gap, the fix, and the underlying lesson (don't describe intent as shipped state — grep first). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
25 lines
679 B
TypeScript
25 lines
679 B
TypeScript
// Non-enumerable flag used by every ILogger implementation to skip
|
|
// already-reported errors. The flag is non-enumerable so JSON.stringify
|
|
// and {...err} spread won't surface it.
|
|
|
|
const REPORTED = "__sentryReported" as const;
|
|
|
|
export function isReported(err: unknown): boolean {
|
|
return (
|
|
err !== null &&
|
|
typeof err === "object" &&
|
|
Boolean((err as Record<string, unknown>)[REPORTED])
|
|
);
|
|
}
|
|
|
|
export function markReported(err: unknown): void {
|
|
if (err !== null && typeof err === "object" && !isReported(err)) {
|
|
Object.defineProperty(err, REPORTED, {
|
|
value: true,
|
|
enumerable: false,
|
|
configurable: false,
|
|
writable: false,
|
|
});
|
|
}
|
|
}
|