Files
agentic-dev/docs/work/epics/library-evaluation-policy/06-sandcastle-reviewer-prompt/_story.md
Danijel Martinek 756e36c720 refactor(work): move epic folders into docs/work/epics/
The previous layout placed epic folders directly under docs/work/
alongside prds/ and _system/. Tightening: epics now live in their
own docs/work/epics/ subfolder, peer to prds/ and _system/. Same
shape as the existing prds/ bucket.

Final docs/work/ layout:
  README.md
  prds/<slug>.prd.md
  _system/_state.json
  epics/<slug>/_epic.md + <story-folder>/_story.md

Renames (git mv preserves history):
- docs/work/binder-wrap-helper/
    -> docs/work/epics/binder-wrap-helper/
- docs/work/library-evaluation-policy/
    -> docs/work/epics/library-evaluation-policy/
- docs/work/ci-security-and-supply-chain/
    -> docs/work/epics/ci-security-and-supply-chain/

Tooling updates:
- state-builder.mjs walks workRoot/epics/ directly; SKIP_FOLDERS
  obsoleted (no more sibling folders to filter out).
- dispatch.mjs's findNextTask, tickStoryBulletInEpic, and
  flipEpicDoneIfAllStoriesDone all join with "epics" segment.
- prd-ship.mjs's deriveShippingCommits walks workRoot/epics/ and
  git-logs docs/work/epics/<epic>/.
- decomposer.prompt.md emits epics under docs/work/epics/<epic-id>/.
- handoff + grill-with-docs glossary references updated.
- Glossary entry for Epic updated.

Reserved future shape: when a task-tracker integration (ClickUp,
Linear) ships, the epics/ subfolder hosts <task-id>-<slug>/
folders. Today it just hosts bare slugs.
2026-05-14 21:21:51 +02:00

2.6 KiB

id, epic, title, type, status, feature, depends-on, blocks, created, updated
id epic title type status feature depends-on blocks created updated
06-sandcastle-reviewer-prompt library-evaluation-policy Sandcastle reviewer prompt — Library-trace check section technical-story done tooling
02-pre-commit-check-script
2026-05-14T06:52:02+02:00 2026-05-14T19:21:52.308Z

Goal

Append a "Library-trace check" section to .sandcastle/reviewer.prompt.md instructing the reviewer agent to run node scripts/library-decisions/check.mjs --staged-against <base> before issuing its verdict, and add the --staged-against <base> flag to check.mjs so it can compare against a given base ref rather than only the git index.

Why

The sandcastle reviewer runs in a clean sandbox where git diff --cached may not reflect the full branch diff. The --staged-against <base> flag allows the reviewer to pass the PR's base branch as the comparison point, giving the same check a CI-compatible code path. Without this, the fourth enforcement layer is advisory only — it has no mechanical check to back it up.

Done when

  • scripts/library-decisions/check.mjs accepts a --staged-against <base> flag; when present, compares git diff <base>...HEAD -- '**/package.json' instead of git diff --cached.
  • check.test.mjs has a new test case: --staged-against main mode with a new feature-tier dep and no trace → exit 1.
  • .sandcastle/reviewer.prompt.md contains a "Library-trace check" section (appended, not replacing existing content) instructing the reviewer to run node scripts/library-decisions/check.mjs --staged-against <base-branch> and reject the slice if it exits non-zero.
  • pnpm lint && pnpm test && pnpm fallow:audit && pnpm coverage:diff all pass.

In scope

  • scripts/library-decisions/check.mjs — add --staged-against flag.
  • scripts/library-decisions/check.test.mjs — add test for the new flag.
  • .sandcastle/reviewer.prompt.md — append the Library-trace check section.

Out of scope

  • Changing the reviewer prompt's existing sections.
  • The pre-commit (index-mode) check behavior — already in Story 02.
  • CI integration (GitHub Actions) — deferred.

Tasks

  • Add --staged-against <base> flag to check.mjs (switches from git diff --cached to git diff <base>...HEAD); add a test covering --staged-against mode (temp git repo fixture, new feature-tier dep, no trace → exit 1); append "Library-trace check" section to .sandcastle/reviewer.prompt.md with the node scripts/library-decisions/check.mjs --staged-against <base> invocation and reject instruction; all gates pass on this single commit.