fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
a5355ee9e7ddaf0fcfe05bfb9fca24c6f6767db2
agentic-dev/docs/work/2026-05-14-library-evaluation-policy/02-pre-commit-check-script/_story.md
Danijel Martinek 16a03e026b chore(work): decompose 2026-05-14-library-evaluation-policy epic 
Decomposer produced 9 stories under docs/work/2026-05-14-library-
evaluation-policy/, ordered to land the schema foundation first and
the cross-referencing content (skill, guide, backfill) last:

01 - trace schema module + docs/library-decisions/ foundation
02 - pre-commit check script
03 - Claude PreToolUse / PostToolUse hooks
04 - evaluate-library skill
05 - human guide (docs/guides/adding-a-library.md)
06 - sandcastle reviewer prompt update
07 - generator pre-shipped traces for optional cores
08 - backfill traces for existing runtime deps
09 - CLAUDE.md Key Conventions bullet

Anchored by ADR-022 + the approved PRD at
docs/work/prds/2026-05-14-library-evaluation-policy.prd.md.
2026-05-14 06:52:02 +02:00

3.1 KiB
Raw Blame History

id, epic, title, type, status, feature, depends-on, blocks
id epic title type status feature depends-on blocks
02-pre-commit-check-script 2026-05-14-library-evaluation-policy Pre-commit check script for library trace presence technical-story todo scripts
01-trace-schema-foundation
06-sandcastle-reviewer-prompt

Goal

Write scripts/library-decisions/check.mjs — the script that walks staged package.json diffs, derives the tier of each affected package, and fails the commit when a new runtime dependency in a feature- or core-tier package has no sibling approved trace staged. Wire it into .husky/pre-commit as step 4.

Why

Human and agent reviewers cannot reliably check trace presence during code review. The pre-commit hook is the last mechanical gate before a dep reaches the repo; it runs unconditionally, composes with --no-verify protection already in the bash-guard hook, and gives the committer immediate actionable feedback.

Done when

  • scripts/library-decisions/check.mjs exists and: (1) reads git diff --cached --name-only -- '**/package.json'; (2) for each staged package.json, derives tier from path (apps/* → app, packages/core-* → core, packages/* → feature); (3) for each newly added line in dependencies (not devDependencies / peerDependencies), checks that docs/library-decisions/*-<name>.md is also staged with decision: approved; (4) exits 1 with a per-package error report + pointer to the skill when any check fails; (5) app-tier and devdep additions exit 0 silently.
  • .husky/pre-commit invokes node scripts/library-decisions/check.mjs after the existing state-sync guard.
  • scripts/library-decisions/check.test.mjs covers (using a temp git repo fixture): new feature-tier dep without trace → exit 1; new feature-tier dep with approved trace staged → exit 0; new feature-tier dep with rejected-decision trace staged → exit 1; new app-tier dep → exit 0; new devdep → exit 0; multi-file diff with mixed pass/fail → exit 1 with per-package report; peerDependencies-only change → exit 0.
  • pnpm typecheck && pnpm lint && pnpm test && pnpm conformance && pnpm fallow:audit && pnpm coverage:diff all pass.

In scope

  • scripts/library-decisions/check.mjs — the check script (imports schema.mjs from Story 01 for trace validation).
  • scripts/library-decisions/check.test.mjs — integration tests using a temp git repo fixture (mirror pattern from scripts/work/state-sync-guard.mjs tests).
  • .husky/pre-commit — one added line.

Out of scope

  • Sandcastle reviewer prompt integration — Story 06.
  • --staged-against <base> flag for CI/sandcastle use — added in Story 06 when the reviewer prompt is written.
  • pnpm libs check ergonomic wrapper — deferred per PRD.

Tasks

  • Write scripts/library-decisions/check.mjs (imports schema from Story 01; parses git diff --cached output; tier derivation from path; staged-trace presence + decision: approved check; exit-1 report with skill pointer); wire into .husky/pre-commit; write check.test.mjs integration tests with temp git repo fixture covering all 7 cases from Done when; all gates pass on this single commit.