fraqtal/agentic-dev
Template
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
bae4b66fa4798a15b0b4a2aa49b3b00bfd00a4fb
agentic-dev/docs/work/library-evaluation-policy/06-sandcastle-reviewer-prompt/_story.md
Danijel Martinek bae4b66fa4 refactor(work): drop date prefixes + move _state.json into _system/ 
Convention shift: epic folders + PRD filenames + frontmatter id
fields are now bare slugs. The created: timestamp (Phase 2) carries
the date; folder names don't repeat it. A future <task-id>-<slug>
shape (e.g. ClickUp) lands cleanly when that integration ships.

Renames (git mv preserves history):
- docs/work/2026-05-13-binder-wrap-helper/
    -> docs/work/binder-wrap-helper/
- docs/work/2026-05-14-library-evaluation-policy/
    -> docs/work/library-evaluation-policy/
- docs/work/2026-05-14-ci-security-and-supply-chain/
    -> docs/work/ci-security-and-supply-chain/
- docs/work/prds/2026-05-13-binder-wrap-helper.prd.md
    -> docs/work/prds/binder-wrap-helper.prd.md
- docs/work/prds/2026-05-13-coverage-architecture.prd.md
    -> docs/work/prds/coverage-architecture.prd.md
- docs/work/prds/2026-05-14-library-evaluation-policy.prd.md
    -> docs/work/prds/library-evaluation-policy.prd.md
- docs/work/prds/2026-05-14-ci-security-and-supply-chain.prd.md
    -> docs/work/prds/ci-security-and-supply-chain.prd.md

Frontmatter updates inside the renamed files: epic id, epic prd,
story epic, PRD id, PRD builds-on all drop date prefixes.

System folder + state file move:
- New docs/work/_system/ holds framework-managed state.
- docs/work/_state.json -> docs/work/_system/_state.json.
- state-builder.mjs adds _system to SKIP_FOLDERS.
- cli.mjs + state-sync-guard.mjs + .husky/pre-commit point at the
  new path.

template-reset-v1 epic deleted entirely (one-off cleanup epic from
the pre-date-convention era; status was already done).

Generator-template updates (so new artifacts ship in the right
shape):
- .sandcastle/decomposer.prompt.md emits bare-slug folder names +
  ISO created: timestamp.
- .claude/skills/to-prd/SKILL.md template uses bare-slug filename +
  bare-slug id field + ISO created: timestamp.

Doc reference updates: glossary, runbook, agent-first-workflow-
and-conformance, reviewer prompt, ADR-020, ADR-022, ADR-023 all
point at the new paths/slugs.
2026-05-14 21:16:51 +02:00

2.6 KiB
Raw Blame History

id, epic, title, type, status, feature, depends-on, blocks, created, updated
id epic title type status feature depends-on blocks created updated
06-sandcastle-reviewer-prompt library-evaluation-policy Sandcastle reviewer prompt — Library-trace check section technical-story done tooling
02-pre-commit-check-script
2026-05-14T06:52:02+02:00 2026-05-14T19:16:52.691Z

Goal

Append a "Library-trace check" section to .sandcastle/reviewer.prompt.md instructing the reviewer agent to run node scripts/library-decisions/check.mjs --staged-against <base> before issuing its verdict, and add the --staged-against <base> flag to check.mjs so it can compare against a given base ref rather than only the git index.

Why

The sandcastle reviewer runs in a clean sandbox where git diff --cached may not reflect the full branch diff. The --staged-against <base> flag allows the reviewer to pass the PR's base branch as the comparison point, giving the same check a CI-compatible code path. Without this, the fourth enforcement layer is advisory only — it has no mechanical check to back it up.

Done when

  • scripts/library-decisions/check.mjs accepts a --staged-against <base> flag; when present, compares git diff <base>...HEAD -- '**/package.json' instead of git diff --cached.
  • check.test.mjs has a new test case: --staged-against main mode with a new feature-tier dep and no trace → exit 1.
  • .sandcastle/reviewer.prompt.md contains a "Library-trace check" section (appended, not replacing existing content) instructing the reviewer to run node scripts/library-decisions/check.mjs --staged-against <base-branch> and reject the slice if it exits non-zero.
  • pnpm lint && pnpm test && pnpm fallow:audit && pnpm coverage:diff all pass.

In scope

  • scripts/library-decisions/check.mjs — add --staged-against flag.
  • scripts/library-decisions/check.test.mjs — add test for the new flag.
  • .sandcastle/reviewer.prompt.md — append the Library-trace check section.

Out of scope

  • Changing the reviewer prompt's existing sections.
  • The pre-commit (index-mode) check behavior — already in Story 02.
  • CI integration (GitHub Actions) — deferred.

Tasks

  • Add --staged-against <base> flag to check.mjs (switches from git diff --cached to git diff <base>...HEAD); add a test covering --staged-against mode (temp git repo fixture, new feature-tier dep, no trace → exit 1); append "Library-trace check" section to .sandcastle/reviewer.prompt.md with the node scripts/library-decisions/check.mjs --staged-against <base> invocation and reject instruction; all gates pass on this single commit.